Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Display a warning box when the CFG contains warnings #4247

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Feb 27, 2024

Manual backport from #4245

After 3liz#4226 and 3liz#4242, the warning message can generate the error `Uncaught SyntaxError: missing ) after argument list`
and `Uncaught ReferenceError: lizUrls is not defined`. These error messages are generated by a quote in the warning message.

To fix it, we use the Lizmap dictionnary which is a JSON version of the Dictionnary local.
@Gustry Gustry added user interface javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Feb 27, 2024
@github-actions github-actions bot added this to the 3.7.5 milestone Feb 27, 2024
@Gustry Gustry merged commit 24aa331 into 3liz:release_3_7 Feb 27, 2024
14 of 15 checks passed
@Gustry Gustry deleted the backport-warning branch February 27, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants