Improve user/group filter to allow multiple users/groups

[nboisteault]

Lizmap Web Client allows filtering the content of vector layers depending on the authenticated user. Before version 3.8, for the attribute filter, every layer to filter must have a field which value must be only one group identifier (or one user login), such as:

id	name	filter_field
1	one	group_a
2	two	group_b
3	three	group_b
4	four	all

This modification allows using a list of groups (or a list of users) separated with a comma (with no spaces) inside the field used as the source of filtering. This will ease showing some features for more than one group (or user). For example, the filtered layer could contain:

id	name	filter_field
1	one	group_a,group_b
2	two	group_b
3	three	group_b,all
4	four	all

We focus on keeping the filter sent to the layer provider as standard as possible, to be able to be directly used by PostgreSQL and avoid evaluating a complex expression on all features.

This new feature is only available:

• for PostgreSQL layers
• if the map editor has chosen to allow multiple values in the filter field (this can be configured in Lizmap desktop plugin)

These safeguards allow Lizmap default behaviour to not change between version 3.7 and 3.8. The map editor will decide to manually activate this new feature. It is safer, as a specific index must be added to have good performance with the new multiple value search.

The filter is built this way:

• we explode the list of groups and use LIKE statements combining all possibilities. For example, the above example will lead to a filter like this if the authenticated user is in the group group_a:

  "filter_field" = 'group_a' OR "filter_field" LIKE 'group_a,%' OR "filter_field" LIKE '%,group_a' OR "filter_field" LIKE '%,group_a,%'
  OR
  "filter_field" = 'all' OR "filter_field" LIKE 'all,%' OR "filter_field" LIKE '%,all' OR "filter_field" LIKE '%,all,%'

• no space must be used between the group (or user) names and commas.

On big datasets, a proper GIN index using the extension pg_trgm is highly recommended.

CREATE EXTENSION IF NOT EXISTS pg_trgm;
CREATE INDEX ON some_schema.some_table USING GIN (filter_field gin_trgm_ops);

Linked to 3liz/qgis-lizmap-server-plugin#86

Funded by: Conseil Départemental du Calvados https://www.calvados.fr/

[Gustry]

LGTM

[Gustry]

> 45 |         await expect(page.locator('[id="jforms_admin_config_section_lizmap\\.repositories\\.view_6"]')).toBeChecked();

E2E tests are failing because of the new group, about the checkboxes in the administration panel, in the "Map repository" creation.

[mdouchin]

> 45 |         await expect(page.locator('[id="jforms_admin_config_section_lizmap\\.repositories\\.view_6"]')).toBeChecked();

E2E tests are failing because of the new group, about the checkboxes in the administration panel, in the "Map repository" creation.

Fixed !

[mdouchin]

The end2end PlayWright test needs 3liz/qgis-lizmap-server-plugin#86 to pass

[mdouchin]

I added the Draft flag again, as I am still working on it to use the new behaviour only:

• for PostgreSQL layers
• if the map editor has chosen to allow multiple values in the filter field.

This will allow Lizmap default behaviour to not change between version 3.7 and 3.8 and let the editor control this new feature. It is safer as a specific index must be added to have good performance with the new multiple value search.

[Gustry]

I add to check during this review, the plugin is generating true boolean values ;-)