Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests - Use URLSearchParams constructor to build querystrings #5058

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Tests - Use URLSearchParams constructor to build querystrings #5058

merged 1 commit into from
Dec 2, 2024

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Dec 2, 2024 •
edited
Loading

@rldhont A follow up from the PR #5053

  • Lines are way shorter, no need to have horizontal scrolling
  • Parameters are automatically escaped, like EXP_Filter: '"gid" = 3'
  • Better with Git, easier to see which parameter is updated later

@Gustry Gustry added tests unit tests and docker configuration for tests javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not backport release_3_8 backport release_3_9 labels Dec 2, 2024
@Gustry Gustry requested a review from rldhont December 2, 2024 18:26
@github-actions github-actions bot added this to the 3.10.0 milestone Dec 2, 2024
rldhont
rldhont approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@rldhont rldhont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Gustry Gustry merged commit 8513b32 into 3liz:master Dec 2, 2024
17 of 18 checks passed
This was referenced Dec 2, 2024
Merged
Merged
@Gustry Gustry deleted the url-params-constructor branch December 2, 2024 19:52
nboisteault pushed a commit to nboisteault/lizmap-web-client that referenced this pull request Dec 12, 2024
@Gustry
Merge pull request 3liz#5058 from Gustry/url-params-constructor
464f755 
Tests - Use URLSearchParams constructor to build querystrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont approved these changes

Assignees
No one assigned
Labels
backport release_3_8 backport release_3_9 javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustry @rldhont