Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute filter - Allow to have a comma separated list of groups or users #86

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

mdouchin
Copy link
Contributor

@mdouchin mdouchin requested a review from Gustry August 14, 2024 13:09
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting for now.

Tests must be upgraded and added

lizmap_server/lizmap_accesscontrol.py Outdated Show resolved Hide resolved
@mdouchin mdouchin force-pushed the attrbute-filter-multiple-values branch from 40ad6ea to ce6381e Compare August 14, 2024 13:35
@Gustry Gustry force-pushed the attrbute-filter-multiple-values branch from 529d9c1 to 9bbd904 Compare August 14, 2024 14:49
@Gustry
Copy link
Member

Gustry commented Aug 21, 2024

@mdouchin Do you LGTM the test side ?

@Gustry
Copy link
Member

Gustry commented Aug 21, 2024

Linked to 3liz/lizmap-web-client#4559

Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use get to check and access at the same time, it's quicker

lizmap_server/lizmap_accesscontrol.py Outdated Show resolved Hide resolved
lizmap_server/lizmap_accesscontrol.py Outdated Show resolved Hide resolved
@mdouchin mdouchin force-pushed the attrbute-filter-multiple-values branch from 37c2c4e to ddb2924 Compare August 22, 2024 15:01
@mdouchin mdouchin merged commit 10dab8e into 3liz:master Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants