fix: corruption in large images when using ssh #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlubas
reviewed
Apr 24, 2024
lua/image/backends/kitty/helpers.lua
Outdated
| @@ -92,6 +92,7 @@ local write_graphics = function(config, data) | |||
| else | |||
| control_payload = "m=1" | |||
| end | |||
| vim.loop.sleep(1) | |||
There was a problem hiding this comment.
vim.loop is being deprecated, you should use vim.uv instead.
There was a problem hiding this comment.
looks great otherwise @SigmaRichards
Uses vim.uv, but allows for vim.loop for older versions of nvim
|
I've updated to use
There's additionally many other places that use |
|
This is great, thank you @SigmaRichards ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #95 . When using ssh, larger images have a chance of corrupting and displaying base64 strings as opposed to rendering the image. Through some testing, adding a sleep call to
write_graphicsseems to fix this issue. Earlier testing showed that it could still occur, but for some time I haven't run into this issue at all.Hoping to get some feedback on whether this fixes the issue for anyone else.
Issue can be recreated by using
ssh localhostas this still uses direct-mode. Then, attempting to render a large image (threshold varies from 30kb to 1mb) will sometimes cause base64 text to be displayed instead of the image. Config settingsmax_width = nil,max_height = nil,max_width_window_percentage = math.hugeandmax_height_window_percentage = math.hugeminimize the chance that the image will be resized below the byte threshold for corruption.