Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rockspec #236

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Enable rockspec #236

merged 3 commits into from
Nov 2, 2024

Conversation

sankantsu
Copy link
Contributor

Closes #191

This PR introduce following changes:

  • Rename *.rockspec.disabled -> *.rockspec to enable lazy.nvim can detect rockspec.
  • Simply use default branch URL for src.url (no need to manual update).
  • Update install instruction for lazy.nvim >= v11.

Re-enabling .rockspec file benefits lazy.nvim users, enabling automic build of image.nvim and magick rocks. It eliminates the need to manually change package.path.

References:

Disclaimer:
I'm not an expert of Lua and Luarocks.

@sankantsu
Copy link
Contributor Author

I noticed that @kevinm6 also suggested similar documentation changes in #193.
Both (this PR and #193) proposes opts.rocks.hererocks = true. But it seems that rocks configuration within defaults does not work for me (hererocks will be not installed and :checkhealth still complains).
c.f. https://lazy.folke.io/configuration

By the way, you can pick some changes from #193, if you think it's appropriate.

@3rd
Copy link
Owner

3rd commented Nov 2, 2024

Thank you, let's merge this one first.
@kevinm6 do you think we need to add documentation from #193 ?

@3rd 3rd merged commit c4d44e7 into 3rd:master Nov 2, 2024
@kevinm6
Copy link
Contributor

kevinm6 commented Nov 2, 2024

I don’t think so @3rd, I’ll close that PR !
Maybe you could move #191 as a Discussion since it can be useful to some people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error wont go away (lazy.nvim luarocks)
3 participants