Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LF ending for commits & check out #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ArthurBandaryk
Copy link
Contributor

No description provided.

@benh
Copy link
Member

benh commented Dec 3, 2021

Is the idea that people can copy this into their project directories? Or can we use symlinks?

@ArthurBandaryk
Copy link
Contributor Author

ArthurBandaryk commented Dec 3, 2021

Is the idea that people can copy this into their project directories? Or can we use symlinks?

My idea is to use a symlink to dev-tools/.gitattributes. (like we use a symlink to .clang-format)
Later I will do the PR's to eventuals , eventuals-grpc and stout which make the users have the symlink to dev-tools/.gitattributes file whenever they clone this repos.

Copy link
Member

@benh benh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, you've tested that git is happy to have .gitattributes be a symlink?

# More about LF vs. CRLF on the link below:
# https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/

* text=auto eol=lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm anxious about the auto and the need to try and have an exhaustive list of binary files otherwise we might brick a binary file ... that sounds like a very unpleasant experience! For example, we're missing pdf below, which I assume that git will properly identify as a binary, but it's weird that we would need to specify things like png but not pdf!? So, I think we should change the experience here. We should add all the files that we know we wnt to have LF line-endings and never possibly brick any files. The failure experience here better, a developer has to come and update the .gitattributes file if we had forgotten to add a particular file type, but no files are bricked!

Please also add a comment in here about how to renormalize all files for the inevitable case that we'll need to run that command when one of us adds another text file extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants