Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyprotoc-plugin as a submodule #276

Closed
CodingCanuck opened this issue Mar 28, 2022 · 2 comments · Fixed by #288
Closed

Add pyprotoc-plugin as a submodule #276

CodingCanuck opened this issue Mar 28, 2022 · 2 comments · Fixed by #288

Comments

@CodingCanuck
Copy link
Contributor

(This issue is sort of a port of 3rdparty/eventuals-grpc#42 [now that the eventuals-grpc repo is read-only] but with a different spin: @while-false please chime in if this approach sounds wrong!)

This repo's version of the pyprotoc-plugin package is stale: we should update it.

Better yet, we should include it as a submodule so that cross-module issues involving pyprotoc-plugin (e.g. https://github.com/reboot-dev/respect-api/issues/17 ) are easier to iterate on within a single locally cloned repo.

@CodingCanuck
Copy link
Contributor Author

Confirmed offline with @while-false that this is a reasonable change, since pyprotoc-plugin is a dependency of eventuals.

CodingCanuck added a commit that referenced this issue Mar 29, 2022
CodingCanuck added a commit that referenced this issue Mar 29, 2022
@CodingCanuck
Copy link
Contributor Author

Added as a submodule in #288

onelxj pushed a commit to onelxj/eventuals that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant