Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyprotoc-plugin as a submodule #288

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

CodingCanuck
Copy link
Contributor

Fixes #276

@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

Waiting for approval before queuing

@CodingCanuck
Copy link
Contributor Author

I tested this by running dazel test //... and seeing tests pass, then making a local non-compiling change to submodules/pyprotoc-plugin/BUILD.bazel and seeing dazel test //... fail.

@CodingCanuck CodingCanuck force-pushed the alexmc.submodule-pyprotoc branch from 4f94e9c to 0995a4e Compare March 29, 2022 17:48
@CodingCanuck CodingCanuck requested a review from rjhuijsman March 29, 2022 17:48
CodingCanuck added a commit to reboot-dev/pyprotoc-plugin that referenced this pull request Mar 29, 2022
Fixes format warnings that appear when adding this repo as a submodule
of eventuals in 3rdparty/eventuals#288.
Copy link
Contributor

@rjhuijsman rjhuijsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

aviator-app bot pushed a commit to reboot-dev/pyprotoc-plugin that referenced this pull request Mar 29, 2022
Fixes format warnings that appear when adding this repo as a submodule
of eventuals in 3rdparty/eventuals#288.
@CodingCanuck CodingCanuck force-pushed the alexmc.submodule-pyprotoc branch from 0995a4e to 930608c Compare March 29, 2022 18:43
@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

Branch up-to-date, waiting for checks.

@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): check_code_style (ubuntu-latest)

CodingCanuck added a commit to reboot-dev/pyprotoc-plugin that referenced this pull request Mar 29, 2022
TESTED=ran `submodules/dev-tools/check-code-style/check_style_bzl.sh` on
a branch with 3rdparty/eventuals#288 which adds
this repo as a submodule of eventuals.
aviator-app bot pushed a commit to reboot-dev/pyprotoc-plugin that referenced this pull request Mar 29, 2022
TESTED=ran `submodules/dev-tools/check-code-style/check_style_bzl.sh` on
a branch with 3rdparty/eventuals#288 which adds
this repo as a submodule of eventuals.
@CodingCanuck CodingCanuck force-pushed the alexmc.submodule-pyprotoc branch from 930608c to c92a92c Compare March 29, 2022 19:00
@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link

aviator-app bot commented Mar 29, 2022

Branch up-to-date, waiting for checks.

@aviator-app aviator-app bot merged commit fd50661 into main Mar 29, 2022
@aviator-app aviator-app bot deleted the alexmc.submodule-pyprotoc branch March 29, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pyprotoc-plugin as a submodule
2 participants