Added copts_ list
#92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`copts_` list contains `-Werror` option in order to turn all warnings into the errors. `-Wno-error=deprecated-declarations` option turns `syscall` warning into a warning even if -Werror is specified. Also I created an issue in the google/glog repo about `syscall` warning [#717](google/glog#717).
ArthurBandaryk
requested review from
benh,
NikitaNikolaenko,
rjhuijsman and
while-false
ArthurBandaryk
force-pushed
the
ArthurBandaryk.Werror
branch
from
68f4b2b to
9b4dd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copts_list contains-Werroroption in order to turn all warnings into theerrors.
-Wno-error=deprecated-declarationsoption turnssyscallwarninginto a warning even if -Werror is specified.
Also I created an issue in the google/glog repo about
syscallwarning#717.