Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow injection of custom bean introspection #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

driabtchik
Copy link

It is rather common to implement POJOs that allow for chaining of setters (i.e. setters are returning "this").
Since BeanMapper relies on Introspector for extraction of properties, the property descriptors for such setters appear as "read-only", without populated setter method.
The change allows injection of customized method for bean introspection, while retaining compatibility with the original approach

@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #120 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
+ Coverage     93.76%   93.85%   +0.08%     
- Complexity      847      851       +4     
============================================
  Files            87       87              
  Lines          1781     1789       +8     
  Branches        173      173              
============================================
+ Hits           1670     1679       +9     
+ Misses           67       66       -1     
  Partials         44       44
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/beanmapper/dynclass/ClassStore.java 87.5% <100%> (ø) 5 <1> (ø) ⬇️
...n/java/io/beanmapper/config/BeanMapperBuilder.java 100% <100%> (ø) 42 <1> (+1) ⬆️
...in/java/io/beanmapper/dynclass/ClassGenerator.java 96.55% <100%> (ø) 19 <1> (ø) ⬇️
...o/beanmapper/core/inspector/PropertyAccessors.java 91.48% <100%> (+2.6%) 17 <1> (+2) ⬆️
...n/java/io/beanmapper/core/BeanPropertyCreator.java 100% <100%> (ø) 12 <1> (ø) ⬇️
...c/main/java/io/beanmapper/core/BeanMatchStore.java 96.82% <100%> (+0.05%) 37 <1> (+1) ⬆️
...n/java/io/beanmapper/config/CoreConfiguration.java 98.01% <100%> (+0.01%) 64 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c58168...be77e88. Read the comment docs.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant