Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

게시판 crud 구현 #4

Open
wants to merge 2 commits into
base: mryoo_main
Choose a base branch
from
Open

게시판 crud 구현 #4

wants to merge 2 commits into from

Conversation

rrrmina
Copy link
Member

@rrrmina rrrmina commented Jul 6, 2023 •
edited
Loading

📌 개요

  • 게시판 crud 간단하게 구현하였습니다.
  • 노션에 있는 컨벤션 적용하였습니다.

💻 작업사항

  • 게시판 작성, 단일/목록 조회, 수정, 삭제 api 구현하였습니다 :)

@rrrmina rrrmina added the enhancement New feature or request label Jul 6, 2023
@rrrmina rrrmina requested a review from a team July 6, 2023 05:28
@rrrmina rrrmina self-assigned this Jul 6, 2023
kmularise
kmularise approved these changes Jul 6, 2023
View reviewed changes
src/main/java/com/example/gg4ndBe/domain/board/dto/BoardDto.java
import lombok.Builder;

public class BoardDto {
public record GetBoardDetailResDto(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java 17이라 record 쓰셨군요!

src/main/java/com/example/gg4ndBe/domain/board/service/BoardService.java
import static com.example.gg4ndBe.common.constant.GlobalConstants.SUCCESS_MESSAGE;

@Service
@AllArgsConstructor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@requiredargsconstructor 말고 @AllArgsConstructor 쓰신 이유가 있을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

별생각없이 사용하였는데 필요가 없겠네요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmularise kmularise kmularise approved these changes

@FeFe2200 FeFe2200 FeFe2200 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@rrrmina rrrmina

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrrmina @FeFe2200 @kmularise