Test fixes, improvements to list_keys and parameterization of S3Annex APIs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n can be specified in send_file. get_upload_info can override max_content_length. Fix moto to use mock_aws
c0state
reviewed
Sep 5, 2024
| ) | ||
| if "Contents" not in response: | ||
| return () | ||
| return tuple(item["Key"] for item in response["Contents"]) |
There was a problem hiding this comment.
This technically might warrant a major version bump
c0state
reviewed
Sep 5, 2024
# Conflicts: # tests/test_s3.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
list_keysreturns generator, respecting pagination.content_dispositioncan be specified insend_file. Still defaults toattachmentget_upload_infocan override max_content_length.S3AnnexFixes
mock_awsmock_awsnow setsAWSAccessKeyIdtoFOOBARKEY, fix this in testyield_fixturein test