Include ReactNode in render method result #1062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinybot
commented
Feb 7, 2024
Comment on lines
+63
to
+66
| new Redirect({ | ||
| from: 'baz', | ||
| to: '/foo', | ||
| }), |
There was a problem hiding this comment.
This is what didn't compile despite it being valid.
jquense
reviewed
Feb 7, 2024
src/createElements.tsx
Outdated
| @@ -20,7 +20,7 @@ export default function createElements( | |||
| routeMatches: Array<RouteMatch>, | |||
| Components: React.ComponentType<any>[], | |||
| matchData: any, | |||
| ): Array<ResolvedElement | undefined> { | |||
| ): Array<React.ReactNode | ResolvedElement | undefined> { | |||
There was a problem hiding this comment.
I don't think this is the correct fix, This method _doesn't) actually return a ReactNode, it only turns route component elements. The problem is Redirect.render shouldn't return a ReactNode
There was a problem hiding this comment.
Oh ok. I didn't do that since it was a potentially breaking change. I've changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061