Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cob_relayboard #347

Conversation

floweisshardt
Copy link
Contributor

@floweisshardt floweisshardt commented Jul 31, 2017

@fmessmer
Copy link
Contributor

fmessmer commented Jul 31, 2017

do not merge (yet)
raw3-1 still use the fake node as it does not have phidgets https://github.com/ipa320/cob_robots/blob/indigo_dev/cob_bringup/robots/raw3-1.xml#L33-L37

the relayboard_sim node could be moved to https://github.com/ipa320/cob_command_tools/tree/indigo_dev/cob_helper_tools/scripts maybe?

@fmessmer
Copy link
Contributor

fmessmer commented Aug 1, 2017

a proper flexisoft_sim node has been added in ipa320/cob_substitute#46
thus, cob4's do not require cob_relayboard anymore...

still raw3-1 issue persists

@floweisshardt
Copy link
Contributor Author

I wouldn't add it to cob_helper_tools as it has nothing to do woth the rest in this package and would only add additional dependencies.

In my opinion raw3-1 does not need the simulated node as soon as we're using canopen with the cob_omni_driver_controller instead of the outdated cob_undercarriage_control. Until this is done, I'm fine with using the sim node from sick_flexisoft for raw3-1 as we have this dependency anyway in cob_bringup.

@fmessmer
Copy link
Contributor

fmessmer commented Aug 4, 2017

Do not merge (yet)
will be investigated in ipa320/cob_robots#703

@fmessmer
Copy link
Contributor

fmessmer commented Sep 6, 2017

How do we deal with this?
See ipa320/care-o-bot#46 (comment)

@fmessmer
Copy link
Contributor

let's keep these packages for the time being...we can still remove them once they require more maintenance effort in the future

@fmessmer fmessmer closed this Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants