Testing improvements for snovault and indirectly for cgap #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netsettler
commented
Feb 3, 2023
| # which was an object that was always less than any other version than itself. | ||
| # We don't care about negative versions, so let's just say that parse_version | ||
| # for our purposes can return version 0. | ||
| return raw_parse_version(version_string or '0') |
There was a problem hiding this comment.
I fussed a bit about whether to default this to '-9999', '0', or '1', but I think we never use negative versions and '0' is therefore the lower bound. And I wanted a way to distinguish between this default and the earliest version I thought was likely to be specified explicitly, which is probably '1'.
Comment on lines
+950
to
+955
| cached = _sid_cache(request) | ||
| found_sid = cached.get(linked['uuid']) | ||
| if not found_sid: | ||
| db_res = request.registry[STORAGE].write.get_by_uuid(linked['uuid']) | ||
| if db_res: | ||
| request._sid_cache[linked['uuid']] = db_res.sid | ||
| found_sid = request._sid_cache.get(linked['uuid']) | ||
| cached[linked['uuid']] = found_sid = db_res.sid |
There was a problem hiding this comment.
I changed the logic here so please double-check carefully, but I think this way of expressing what found_sid is will be easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.