Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sheet_utils refactor to add csv functionality (C4-1088) #276

Open
wants to merge 17 commits into
base: kmp_sheet_utils
Choose a base branch
from
Open

sheet_utils refactor to add csv functionality (C4-1088) #276

wants to merge 17 commits into from

Commits on Aug 17, 2023

  1. First cut at useful functionality.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3ff63a9 View commit details
    Browse the repository at this point in the history

  2. Some name changes to make things more abstract. workbook becomes read… 

    …er_agent, for example
    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    39bd2e0 View commit details
    Browse the repository at this point in the history

  3. Rename sheetname to tabname throughout, to be more clear that this is… 

    … not the workbook level artifact. Better handling of init args.
    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    77b72f6 View commit details
    Browse the repository at this point in the history

  4. Add some doc strings. Rename load_table_set to just load. Arrange for… 

    … ItemManager.load to take a tab_name argument so that CSV files can perhaps infer a type name.
    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ba8c55c View commit details
    Browse the repository at this point in the history

  5. Add load_items function. Fix some test names. Update changelog.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    50488cb View commit details
    Browse the repository at this point in the history

  6. Experimental bug fix from Will to hopefully make get_schema_names work.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    807e525 View commit details
    Browse the repository at this point in the history

  7. update changelog

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2a8e81a View commit details
    Browse the repository at this point in the history

  8. Update dcicutils/sheet_utils.py 

    Co-authored-by: drio18 <[email protected]>
    @netsettler @drio18
    netsettler and drio18 authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    718054a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'kmp_sheet_utils' into kmp_sheet_utils_refactor_for_csv

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    582f002 View commit details
    Browse the repository at this point in the history

  10. Add some comments in response to Doug's code review.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    56d1459 View commit details
    Browse the repository at this point in the history

  11. Support TSV files.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2facf9e View commit details
    Browse the repository at this point in the history

  12. Add changelog info about tsv files.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    bcc4e63 View commit details
    Browse the repository at this point in the history

  13. Add a missing data file.

    @netsettler
    netsettler committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9de282e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'kmp_sheet_utils' into kmp_sheet_utils_refactor_for_csv

    @netsettler
    netsettler committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    08d428e View commit details
    Browse the repository at this point in the history

  2. Backport some small fixes and cosmetics from the schemas branch.

    @netsettler
    netsettler committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    60ada3f View commit details
    Browse the repository at this point in the history

  3. Add some missing newlines in data files.

    @netsettler
    netsettler committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    946b998 View commit details
    Browse the repository at this point in the history

  4. Support for coping with .tsv files where trailing whitespace is 'help… 

    …fully' removed by an editor that doesn't understand such whitespace might be significant in TSVs.
    @netsettler
    netsettler committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    36e7de0 View commit details
    Browse the repository at this point in the history