Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransferUtils #288

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

TransferUtils #288

wants to merge 8 commits into from

Conversation

willronchetti
Copy link
Member

  • A small addition to provision some baseline utilities for downloading files in parallel from the portal and from searches
  • TODO: update with patching functionality once data model is in place

@coveralls
Copy link

coveralls commented Sep 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6355336442

  • 1 of 81 (1.23%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 77.096%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/ff_utils.py 1 5 20.0%
dcicutils/transfer_utils.py 0 76 0.0%
Totals Coverage Status
Change from base Build 6354871296: -0.6%
Covered Lines: 8479
Relevant Lines: 10998
💛 - Coveralls

dmichaels-harvard
dmichaels-harvard reviewed Sep 29, 2023
View reviewed changes
dcicutils/ff_utils.py
auth = get_authentication_with_server(key, ff_env)
get_url = '/'.join([auth['server'], _sls(obj_id)]).rstrip('/') + '/@@download'
response = authorized_request(get_url, auth=auth, verb='GET', allow_redirects=False)
return response.headers['Location']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this check for a 301?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the @@download at the end it will throw exception prior either way if it doesn't find it, so not sure there is a huge point (there is no scenario where 301 isn't returned and this code is reached, it would have thrown exception prior to this point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmichaels-harvard dmichaels-harvard dmichaels-harvard left review comments

@netsettler netsettler Awaiting requested review from netsettler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willronchetti @coveralls @dmichaels-harvard