General code cleanup from Clion-Tidy warnings

[ctadlock]

There are several more warnings that should be looked at, particularly narrowing of data types.

[James-4DSystems]

Hello ctadlock, thanks for submitted this pull request.

Doing some basic checks, the changes you have proposed fails to compile on boards such as the Arduino Uno, and Arduino Mega, and possibly others.
Do you have a suggestion for the changes you have made, to enable it to compile on all the popular Arduino boards?
It does seem to compile and work fine with an older SAM based Arduino Due, and a ESP32 board, however the older 'legacy' Arduino boards it will not compile for.

At this time we cannot merge your request - please do advise if you have any suggestions.

[James-4DSystems]

Hello again Ctaglock,

For some tests I changed in the .cpp file the header to be this

#if defined (AVR)
   #include <math.h>
   #include <string.h>
#else
   #include <cmath>
   #include <cstring>
#endif

And now it compiles fine for Uno, Mega, ESP32, Due etc.

Just wondering if you can explain what the reason was to change from math.h to cmath, and string.h to cstring, in the first place?

Going one step back again and just simply having

#include <math.h>
#include <string.h>

Seems to work for all of them too.

If you can explain this, that would be great information to have. Is there something specific in these 2 new includes that the originals did not have?