fix: local load/write validate and refactor #8906
Annotations
1 error and 11 warnings
Run reviewdog/action-cpplint@master
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Run reviewdog/action-cpplint@master:
hybridse/include/node/sql_node.h#L984
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
hybridse/include/node/sql_node.h:984: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Run reviewdog/action-cpplint@master:
hybridse/include/node/sql_node.h#L984
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
hybridse/include/node/sql_node.h:984: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L17
[cpplint] reported by reviewdog 🐶
#ifndef header guard has wrong style, please use: SRC_SDK_OPTIONS_MAP_PARSER_H_ [build/header_guard] [5]
Raw Output:
src/sdk/options_map_parser.h:17: #ifndef header guard has wrong style, please use: SRC_SDK_OPTIONS_MAP_PARSER_H_ [build/header_guard] [5]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L265
[cpplint] reported by reviewdog 🐶
#endif line should be "#endif // SRC_SDK_OPTIONS_MAP_PARSER_H_" [build/header_guard] [5]
Raw Output:
src/sdk/options_map_parser.h:265: #endif line should be "#endif // SRC_SDK_OPTIONS_MAP_PARSER_H_" [build/header_guard] [5]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L36
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
src/sdk/options_map_parser.h:36: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L113
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
src/sdk/options_map_parser.h:113: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L207
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
src/sdk/options_map_parser.h:207: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser.h#L221
[cpplint] reported by reviewdog 🐶
Add #include <vector> for vector<> [build/include_what_you_use] [4]
Raw Output:
src/sdk/options_map_parser.h:221: Add #include <vector> for vector<> [build/include_what_you_use] [4]
|
Run reviewdog/action-cpplint@master:
src/sdk/options_map_parser_test.cc#L42
[cpplint] reported by reviewdog 🐶
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw Output:
src/sdk/options_map_parser_test.cc:42: At least two spaces is best between code and comments [whitespace/comments] [2]
|
Run reviewdog/action-cpplint@master:
src/sdk/sql_cluster_router.cc#L2833
[cpplint] reported by reviewdog 🐶
Missing space before ( in if( [whitespace/parens] [5]
Raw Output:
src/sdk/sql_cluster_router.cc:2833: Missing space before ( in if( [whitespace/parens] [5]
|
The logs for this run have expired and are no longer available.
Loading