Skip to content

Commit

Permalink
feat: use local logger instead of slf4j annotation which causes compi…
Browse files Browse the repository at this point in the history
…le fail (#3894)

* Use local logger instead of slf4j annotation which causes compile fail

* Change log to logger in taskmanager server
  • Loading branch information
tobegit3hub authored Apr 25, 2024
1 parent 357d45f commit 29b1e0b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import org.apache.commons.csv.CSVRecord;
import org.apache.commons.csv.QuoteMode;
import org.apache.commons.io.FileUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

import java.io.BufferedReader;
import java.io.File;
Expand All @@ -51,6 +53,8 @@
*/
@Slf4j
public class JobResultSaver {
private static final Log log = LogFactory.getLog(JobResultSaver.class);

// false: unused, true: using
// 0: unused, 1: saving, 2: finished but still in use
private List<Integer> idStatus;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ public void startRpcServer(Boolean blocking) throws ConfigException, Interrupted
rpcServer = new RpcServer(TaskManagerConfig.getServerPort(), options);
rpcServer.registerService(new TaskManagerImpl());
rpcServer.start();
log.info("Start TaskManager on {} with worker thread number {}", TaskManagerConfig.getServerPort(),
TaskManagerConfig.getServerWorkerThreads());
logger.info(String.format("Start TaskManager on %d with worker thread number %d",
TaskManagerConfig.getServerPort(), TaskManagerConfig.getServerWorkerThreads()));

if (blocking) {
// make server keep running
Expand Down

0 comments on commit 29b1e0b

Please sign in to comment.