Skip to content

Commit

Permalink
fix(optimizer): KeysOptimizedImpl
Browse files Browse the repository at this point in the history
  • Loading branch information
@aceforeverd
aceforeverd committed Oct 15, 2023
1 parent a8d4d63 commit a477dc2
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions hybridse/src/passes/physical/group_and_sort_optimized.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ bool GroupAndSortOptimized::KeysOptimizedImpl(const SchemasContext* root_schemas
}
} else if (PhysicalOpType::kPhysicalOpSimpleProject == in->GetOpType()) {
PhysicalOpNode* new_depend;
if (!KeysOptimized(in->GetProducer(0)->schemas_ctx(), in->GetProducer(0), left_key, index_key, right_key, sort,
if (!KeysOptimizedImpl(in->GetProducer(0)->schemas_ctx(), in->GetProducer(0), left_key, index_key, right_key, sort,

Check warning on line 461 in hybridse/src/passes/physical/group_and_sort_optimized.cc

View workflow job for this annotation

GitHub Actions / cpplint 

[cpplint] reported by reviewdog 🐶
 Lines should be <= 120 characters long  [whitespace/line_length] [2]

Raw Output:
hybridse/src/passes/physical/group_and_sort_optimized.cc:461:  Lines should be <= 120 characters long  [whitespace/line_length] [2]
&new_depend)) {
return false;
}
Expand All @@ -475,7 +475,7 @@ bool GroupAndSortOptimized::KeysOptimizedImpl(const SchemasContext* root_schemas
return true;
} else if (PhysicalOpType::kPhysicalOpRename == in->GetOpType()) {
PhysicalOpNode* new_depend;
if (!KeysOptimized(in->GetProducer(0)->schemas_ctx(), in->producers()[0], left_key,
if (!KeysOptimizedImpl(in->GetProducer(0)->schemas_ctx(), in->producers()[0], left_key,
index_key, right_key, sort, &new_depend)) {
return false;
}
Expand All @@ -493,7 +493,7 @@ bool GroupAndSortOptimized::KeysOptimizedImpl(const SchemasContext* root_schemas
PhysicalFilterNode* filter_op = dynamic_cast<PhysicalFilterNode*>(in);

PhysicalOpNode* new_depend;
if (!KeysOptimized(root_schemas_ctx, in->producers()[0], left_key, index_key, right_key, sort, &new_depend)) {
if (!KeysOptimizedImpl(root_schemas_ctx, in->producers()[0], left_key, index_key, right_key, sort, &new_depend)) {

Check warning on line 496 in hybridse/src/passes/physical/group_and_sort_optimized.cc

View workflow job for this annotation

GitHub Actions / cpplint 

[cpplint] reported by reviewdog 🐶
 Lines should be <= 120 characters long  [whitespace/line_length] [2]

Raw Output:
hybridse/src/passes/physical/group_and_sort_optimized.cc:496:  Lines should be <= 120 characters long  [whitespace/line_length] [2]
return false;
}
PhysicalFilterNode* new_filter = nullptr;
Expand All @@ -511,7 +511,7 @@ bool GroupAndSortOptimized::KeysOptimizedImpl(const SchemasContext* root_schemas
// window partition by and order by columns must refer to the left most table only
PhysicalOpNode* new_depend = nullptr;
auto* rebase_sc = in->GetProducer(0)->schemas_ctx();
if (!KeysOptimized(rebase_sc, in->GetProducer(0), left_key, index_key, right_key, sort,
if (!KeysOptimizedImpl(rebase_sc, in->GetProducer(0), left_key, index_key, right_key, sort,
&new_depend)) {
return false;
}
Expand All @@ -531,7 +531,7 @@ bool GroupAndSortOptimized::KeysOptimizedImpl(const SchemasContext* root_schemas
// window partition by and order by columns must refer to the left most table only
PhysicalOpNode* new_depend = nullptr;
auto* rebase_sc = in->GetProducer(0)->schemas_ctx();
if (!KeysOptimized(rebase_sc, in->GetProducer(0), left_key, index_key, right_key, sort,
if (!KeysOptimizedImpl(rebase_sc, in->GetProducer(0), left_key, index_key, right_key, sort,
&new_depend)) {
return false;
}
Expand Down

0 comments on commit a477dc2

Please sign in to comment.