test: fix plan tests

4paradigm · Mar 4, 2024 · ed63fff · ed63fff
1 parent 775d49d
commit ed63fff
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 16 deletions.
diff --git a/cases/plan/error_unsupport_sql.yaml b/cases/plan/error_unsupport_sql.yaml
@@ -56,11 +56,6 @@ cases:
     desc: 表路径层级超过边界2
     sql: |
       select db.t1.level3.* from t;
-  - id: 9
-    desc: Insert 非常量
-    mode: request-unsupport
-    sql: |
-      insert into t1 values(1, 2, aaa);
   - id: in_predicate_subquery
     desc: test_expr in subquery
     sql: |

diff --git a/cases/query/udf_query.yaml b/cases/query/udf_query.yaml
@@ -574,7 +574,7 @@ cases:
         map('1', 2, '1', 4, '1', 6, '7', 8, '9', 10, '11', 12)['1'] as e9,
         # map("c", 99, "d", NULL)["d"] as e10,
     expect:
-      # FIXME
+      # FIXME(someone): add e10 result core dump occasionally on centOS
       columns: ["e1 string", "e2 int", "e3 string", "e4 int", "e5 string", "e6 timestamp", "e7 int", "e8 int", "e9 int"]
       data: |
         2, 100, NULL, 101, f, 2000, 10, NULL, 2

diff --git a/hybridse/src/planv2/ast_node_converter_test.cc b/hybridse/src/planv2/ast_node_converter_test.cc
@@ -868,12 +868,6 @@ TEST_F(ASTNodeConverterTest, ConvertInsertStmtFailTest) {
         )sql";
         expect_converted(sql, common::kSqlAstError, "Un-support Named Parameter Expression a");
     }
-    {
-        const std::string sql = R"sql(
-        INSERT into t1 values (1, 2L, aaa)
-        )sql";
-        expect_converted(sql, common::kSqlAstError, "Un-support insert statement with un-const value");
-    }
 }
 TEST_F(ASTNodeConverterTest, ConvertStmtFailTest) {
     node::NodeManager node_manager;

diff --git a/hybridse/src/planv2/planner_v2_test.cc b/hybridse/src/planv2/planner_v2_test.cc
@@ -16,16 +16,13 @@
 
 #include "planv2/planner_v2.h"
 
-#include <memory>
 #include <utility>
 #include <vector>
 
 #include "case/sql_case.h"
 #include "gtest/gtest.h"
 #include "plan/plan_api.h"
-#include "zetasql/parser/parser.h"
-#include "zetasql/public/error_helpers.h"
-#include "zetasql/public/error_location.pb.h"
+
 namespace hybridse {
 namespace plan {