Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support delete(aggregator) #3327

Merged
merged 59 commits into from
Nov 14, 2023
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 19, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (190992d) 75.33% compared to head (823a2b1) 75.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #3327    +/-   ##
==========================================
  Coverage     75.33%   75.33%            
  Complexity      587      587            
==========================================
  Files           718      718            
  Lines        129780   130018   +238     
  Branches       1280     1280            
==========================================
+ Hits          97765    97951   +186     
- Misses        31729    31781    +52     
  Partials        286      286            
Files Coverage Δ
src/storage/aggregator.h 100.00% <ø> (ø)
src/storage/aggregator_test.cc 98.34% <100.00%> (+<0.01%) ⬆️
src/storage/disk_table.h 83.78% <ø> (ø)
src/storage/mem_table.h 100.00% <ø> (ø)
src/storage/table.h 92.85% <ø> (ø)
src/tablet/combine_iterator.h 65.57% <100.00%> (ø)
src/storage/mem_table.cc 89.11% <95.23%> (+0.87%) ⬆️
src/tablet/tablet_impl_test.cc 99.53% <99.50%> (-0.02%) ⬇️
src/storage/disk_table.cc 86.12% <58.33%> (ø)
src/storage/aggregator.cc 78.32% <84.90%> (+1.40%) ⬆️
... and 1 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jul 18, 2023
@dl239 dl239 marked this pull request as ready for review July 18, 2023 04:10
@dl239 dl239 enabled auto-merge (squash) November 14, 2023 07:07
@dl239 dl239 merged commit 9401a5e into 4paradigm:main Nov 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants