Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: dynamic link gflags/glog #3439

Closed
wants to merge 12 commits into from

Conversation

aceforeverd
Copy link
Collaborator

thirdparty source improves:

  • include farmhash in source directly
  • dyanmic link gflags/glog
  • upgrade gflags/glog to latest version

fixes #3407

@github-actions github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -38.41% ⚠️

Comparison is base (e2dd0a5) 75.72% compared to head (694ad7b) 37.32%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3439       +/-   ##
=============================================
- Coverage     75.72%   37.32%   -38.41%     
  Complexity      414      414               
=============================================
  Files           703      178      -525     
  Lines        127271    10308   -116963     
  Branches       1206     1206               
=============================================
- Hits          96371     3847    -92524     
+ Misses        30659     6220    -24439     
  Partials        241      241               

see 525 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd marked this pull request as draft August 15, 2023 07:37
@github-actions github-actions bot added the workflow CICD related label Aug 16, 2023
@aceforeverd
Copy link
Collaborator Author

fixed by #3778

@aceforeverd aceforeverd closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openmldb batch tests fails to bootstrap on mac
1 participant