feat(udf): support datediff dates before 1900
#3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3499 +/- ##
=============================================
+ Coverage 37.14% 75.35% +38.20%
Complexity 414 414
=============================================
Files 179 707 +528
Lines 10364 128677 +118313
Branches 1191 1191
=============================================
+ Hits 3850 96962 +93112
- Misses 6273 31474 +25201
Partials 241 241
☔ View full report in Codecov by Sentry. |
aceforeverd
force-pushed
the
feat-datediff-date2
branch
2 times, most recently
from
80a6da2 to
6e8cc2e
Compare
aceforeverd
commented
Sep 11, 2023
aceforeverd
force-pushed
the
feat-datediff-date2
branch
from
6e8cc2e to
4e14ea0
Compare
aceforeverd
requested review from
dl239,
tobegit3hub,
vagetablechicken,
zhanghaohit and
lqy222
vagetablechicken
approved these changes
Sep 21, 2023
dl239
approved these changes
Sep 26, 2023
lqy222
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
datadifffunction with at least one string parameter, the string date is allowed to be before year 1900.NOTE: openmldb date type only supports year after 1900.