build: upgrade thirdparty to 0.6.0 #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aceforeverd
commented
Oct 17, 2023
•
aceforeverd
commented
- upgrade thirdparty, which upgrade brpc to 1.6.0
- calls some teardown function before nameserver destructor, it mitigate cases like pure virtual method called #3416
it upgrade brpc to 1.6.0
github-actions
bot
added
build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
=============================================
- Coverage 83.35% 75.30% -8.05%
- Complexity 0 587 +587
=============================================
Files 17 718 +701
Lines 751 129787 +129036
Branches 0 1280 +1280
=============================================
+ Hits 626 97737 +97111
- Misses 109 31764 +31655
- Partials 16 286 +270
☔ View full report in Codecov by Sentry. |
aceforeverd
force-pushed
the
build-thirdparty-0.6.0
branch
from
e6193ea to
bfa81f2
Compare
github-actions
bot
added
the
storage-engine
aceforeverd
force-pushed
the
build-thirdparty-0.6.0
branch
from
5d32ca7 to
776af30
Compare
aceforeverd
requested review from
dl239,
vagetablechicken,
tobegit3hub and
lqy222
and removed request for
dl239
dl239
reviewed
Oct 26, 2023
aceforeverd
force-pushed
the
build-thirdparty-0.6.0
branch
from
776af30 to
f4b478e
Compare
dl239
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.