Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gc coredump #3561

Merged
merged 4 commits into from
Nov 15, 2023
Merged

fix: fix gc coredump #3561

merged 4 commits into from
Nov 15, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Oct 19, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9190ecf) 75.25% compared to head (8f0891e) 75.33%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3561      +/-   ##
============================================
+ Coverage     75.25%   75.33%   +0.07%     
  Complexity      587      587              
============================================
  Files           701      718      +17     
  Lines        129041   129842     +801     
  Branches       1280     1280              
============================================
+ Hits          97115    97821     +706     
- Misses        31640    31735      +95     
  Partials        286      286              
Files Coverage Δ
src/storage/mem_table.cc 88.24% <100.00%> (-0.69%) ⬇️
src/storage/snapshot_test.cc 99.80% <100.00%> (+<0.01%) ⬆️

... and 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 enabled auto-merge (squash) November 14, 2023 03:19
@dl239 dl239 merged commit bb6bc09 into 4paradigm:main Nov 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants