Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set spark_config and use to request taskmanager #3613

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub commented Nov 21, 2023

Resolve #3592 .

Usage:

image

@tobegit3hub tobegit3hub self-assigned this Nov 21, 2023
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (72f752b) 40.20% compared to head (0d4d3a3) 74.95%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/sdk/sql_cluster_router.cc 3.12% 31 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3613       +/-   ##
=============================================
+ Coverage     40.20%   74.95%   +34.74%     
  Complexity      640      640               
=============================================
  Files           191      724      +533     
  Lines         11209   130390   +119181     
  Branches       1318     1318               
=============================================
+ Hits           4507    97734    +93227     
- Misses         6409    32363    +25954     
  Partials        293      293               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobegit3hub tobegit3hub requested review from vagetablechicken and dl239 and removed request for vagetablechicken November 28, 2023 09:35
@tobegit3hub tobegit3hub enabled auto-merge (squash) November 28, 2023 10:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 29, 2023
@tobegit3hub tobegit3hub merged commit 71cf61e into 4paradigm:main Nov 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setting spark configuration for Java SDK
3 participants