Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop non empty offline path #3654

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: drop non empty offline path #3654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...nmldb-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/JobInfoManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,7 @@
val offlineTableInfo = tableInfo.getOfflineTableInfo

val filePath = offlineTableInfo.getPath
if(offlineTableInfo.getDeepCopy) {

if(filePath.nonEmpty) {
if (filePath.startsWith("file://")) {
val dir = new File(filePath.substring(7))
logger.info(s"Try to delete the path ${filePath.substring(7)}")
Expand All @@ -217,7 +216,7 @@
throw new Exception(s"Get unsupported file path: $filePath")
}
} else {
logger.info(s"Do not delete file $filePath for non deep copy data")
logger.info(s"Do not delete for empty hard path")

Check warning on line 219 in java/openmldb-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/JobInfoManager.scala

View check run for this annotation

Codecov / codecov/patch

java/openmldb-taskmanager/src/main/scala/com/_4paradigm/openmldb/taskmanager/JobInfoManager.scala#L219 

Added line #L219 was not covered by tests
}
}

Expand Down
Loading