Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zk reconnect in db sdk #3656

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

vagetablechicken
Copy link
Collaborator

closes #3602

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7d89892) 74.97% compared to head (d4341ab) 74.95%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/zk/zk_client.cc 50.00% 7 Missing ⚠️
src/sdk/db_sdk.cc 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3656      +/-   ##
============================================
- Coverage     74.97%   74.95%   -0.03%     
  Complexity      640      640              
============================================
  Files           724      724              
  Lines        130359   130779     +420     
  Branches       1318     1325       +7     
============================================
+ Hits          97743    98020     +277     
- Misses        32323    32466     +143     
  Partials        293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit 40eaf50 into 4paradigm:main Dec 8, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconnect after ZOO_EXPIRED_SESSION_STATE or others in sdk
3 participants