feat: support `create/alter/drop user` statement #3678

dl239 · 2023-12-12T09:29:37Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?

codecov · 2023-12-12T09:47:57Z

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (ff3ef0d) 37.16% compared to head (5f5f3b1) 40.09%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
...n/java/com/_4paradigm/openmldb/jdbc/SQLDriver.java	33.33%	3 Missing and 3 partials ⚠️
.../com/_4paradigm/openmldb/spark/OpenmldbSource.java	0.00%	6 Missing ⚠️
...openmldb/taskmanager/config/TaskManagerConfig.java	0.00%	6 Missing ⚠️
...paradigm/openmldb/taskmanager/JobInfoManager.scala	0.00%	3 Missing ⚠️
...in/java/com/_4paradigm/openmldb/sdk/SdkOption.java	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3678      +/-   ##
============================================
+ Coverage     37.16%   40.09%   +2.92%     
- Complexity      655      657       +2     
============================================
  Files           177      193      +16     
  Lines         10773    11414     +641     
  Branches       1366     1374       +8     
============================================
+ Hits           4004     4576     +572     
- Misses         6470     6535      +65     
- Partials        299      303       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dl239 · 2023-12-21T03:20:36Z

@tobegit3hub will add user relevant information to openmldb-batch in another pr

src/sdk/sql_cluster_router.cc

github-actions · 2024-01-31T07:28:00Z

SDK Test Report

101 files + 1 101 suites +1 2m 8s ⏱️ +11s
344 tests +18 330 ✅ +16 14 💤 +3 0 ❌ - 1
469 runs +18 455 ✅ +16 14 💤 +3 0 ❌ - 1

Results for commit 5f5f3b1. ± Comparison against base commit ff3ef0d.

This pull request removes 48 and adds 45 tests. Note that renamed tests count towards both.

  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…

com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.openmldb.jdbc.SQLRouterSmokeTest ‑ testInsertMeta[com._4paradigm.openmldb.sdk.impl.SqlClusterExecutor@13809363](1)
…

This pull request skips 1 test.

tests.sqlalchemy_api_test.TestSqlalchemyAPI ‑ test_request_timeout

♻️ This comment has been updated with latest results.

github-actions · 2024-01-31T07:45:36Z

HybridSE Mac Test Report

20 064 tests 20 062 ✅ 10m 11s ⏱️
252 suites 2 💤
66 files 0 ❌

Results for commit 5f5f3b1.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-31T07:45:37Z

HybridSE Linux Test Report

20 094 tests 20 092 ✅ 6m 14s ⏱️
255 suites 2 💤
67 files 0 ❌

Results for commit 5f5f3b1.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-31T08:43:33Z

Linux Test Report

57 files ±0 244 suites ±0 1h 17m 47s ⏱️ +57s
12 577 tests +3 12 570 ✅ +3 7 💤 ±0 0 ❌ ±0
17 834 runs +3 17 827 ✅ +3 7 💤 ±0 0 ❌ ±0

Results for commit 5f5f3b1. ± Comparison against base commit ff3ef0d.

♻️ This comment has been updated with latest results.

tobegit3hub

LGTM

feat: add Encrypt

050e2ec

github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Dec 12, 2023

feat: add sql node

b494faa

github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine labels Dec 13, 2023

feat: auth in sdk

4df679d

github-actions bot added api-server and removed storage-engine openmldb storage engine. nameserver & tablet labels Dec 15, 2023

dl239 added 5 commits December 15, 2023 16:18

fix: fix test

5eec977

fix: fix bugs

b7916a5

test: add case

38a1c36

feat: hide password in terminal

d641ab9

feat: update sdk

ff5a7d8

github-actions bot added the sdk openmldb java/python sdk label Dec 18, 2023

dl239 and others added 2 commits December 19, 2023 10:12

fix: fix test

4e69eb0

feat: add user in spark

38d71f9

github-actions bot added the task-manager openmldb taskmanager label Dec 19, 2023

dl239 added 3 commits December 19, 2023 16:22

fix: fix python

805ed38

docs: add doc

235509b

fix: skip python test

b32f24c

github-actions bot added the documentation Improvements or additions to documentation label Dec 19, 2023

dl239 marked this pull request as ready for review December 19, 2023 10:19

dl239 changed the title ~~feat: support create user statement~~ feat: support create/alter/drop user statement Dec 19, 2023

dl239 commented Dec 21, 2023

View reviewed changes

src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved

dl239 commented Dec 21, 2023

View reviewed changes

src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved

dl239 commented Dec 21, 2023

View reviewed changes

src/sdk/sql_cluster_router.cc Outdated Show resolved Hide resolved

fix: fix comment

430967d

dl239 mentioned this pull request Dec 27, 2023

Delete SQLClusterRouter from nameserver #1697

Closed

dl239 mentioned this pull request Jan 8, 2024

Add user authentication to offline related modules #3694

Open

dl239 and others added 5 commits January 8, 2024 12:07

merge main

3da6da7

fix: revert HandleDelete

9abd332

feat: add user to openmldb-import

ad3d61b

merge main

94e3019

merge main

2df57b2

fix: fix alter root password

5f5f3b1

tobegit3hub approved these changes Feb 2, 2024

View reviewed changes

lqy222 approved these changes Feb 2, 2024

View reviewed changes

tobegit3hub merged commit 7ca5f44 into 4paradigm:main Feb 2, 2024
30 of 33 checks passed

tobegit3hub mentioned this pull request Feb 4, 2024

feat: support username password in offline #3744

Merged

dl239 deleted the feat/create_user branch February 5, 2024 06:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support `create/alter/drop user` statement #3678

feat: support `create/alter/drop user` statement #3678

dl239 commented Dec 12, 2023

codecov bot commented Dec 12, 2023 •

edited

Loading

dl239 commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

tobegit3hub left a comment

feat: support create/alter/drop user statement #3678

feat: support create/alter/drop user statement #3678

Conversation

dl239 commented Dec 12, 2023

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

dl239 commented Dec 21, 2023 • edited Loading

github-actions bot commented Jan 31, 2024 • edited Loading

SDK Test Report

github-actions bot commented Jan 31, 2024 • edited Loading

HybridSE Mac Test Report

github-actions bot commented Jan 31, 2024 • edited Loading

HybridSE Linux Test Report

github-actions bot commented Jan 31, 2024 • edited Loading

Linux Test Report

tobegit3hub left a comment

Choose a reason for hiding this comment

feat: support `create/alter/drop user` statement #3678

feat: support `create/alter/drop user` statement #3678

codecov bot commented Dec 12, 2023 •

edited

Loading

dl239 commented Dec 21, 2023 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot commented Jan 31, 2024 •

edited

Loading