-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map): cast null or map() to explicit map type #3847
Conversation
SDK Test Report101 files ±0 101 suites ±0 2m 13s ⏱️ ±0s Results for commit 38978b9. ± Comparison against base commit 7f758af. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Linux Test Report 57 files 244 suites 1h 39m 51s ⏱️ Results for commit 38978b9. ♻️ This comment has been updated with latest results. |
2991987
to
c14fa9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
============================================
+ Coverage 74.87% 74.88% +0.01%
Complexity 658 658
============================================
Files 742 742
Lines 133925 134056 +131
Branches 1387 1387
============================================
+ Hits 100277 100391 +114
- Misses 33344 33361 +17
Partials 304 304 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Auto casting to target type when necessary, which usually happens with insert statement while a default schema defined by target table. This supports constructing null or empty values from offline engine.
c14fa9f
to
38978b9
Compare
Enhancements to new insert row builder:
Auto casting to target type when necessary, which usually happens with insert statement while a default schema defined by target table.
With the patch (whenever
InsertRowBuilder
used), it canNULL
place holder, so insert statement likeinsert to t1 values (1, null, null, map())
simply work for table t1(int, timestamp, map<int, string>, map<timestamp, int>)