Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle repeated sort keys and sort as int #3946

Closed
wants to merge 3 commits into from
Closed

fix: handle repeated sort keys and sort as int #3946

wants to merge 3 commits into from

Conversation

oh2024
Copy link
Collaborator

@oh2024 oh2024 commented Jun 4, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)

  1. json_array_sort drops duplicate sort keys
  2. json_array_sort sorts by string instead of int
  • What is the new behavior (if this is a feature change)?
  1. json_array_sort does not drop duplicate sort keys
  2. json_array_sort sorts by int instead of string, and breaks ties using output column

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 4, 2024
@oh2024 oh2024 changed the base branch from feat-custom-udf to feat-custom-udf-068 June 5, 2024 05:09
@oh2024 oh2024 changed the base branch from feat-custom-udf-068 to feat-custom-udf June 5, 2024 05:18
@oh2024 oh2024 closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aceforeverd aceforeverd aceforeverd left review comments

Assignees
No one assigned
Labels
execute-engine hybridse sql engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oh2024 @aceforeverd