Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): cmake error install files given directory for tools/validation #3976

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Shouren
Copy link
Collaborator

@Shouren Shouren commented Aug 30, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    CMake Error for tools/validation #3975

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the build openmldb compiling and installing label Aug 30, 2024
@Shouren Shouren requested review from dl239 and zhanghaohit August 30, 2024 03:31
@Shouren Shouren changed the title CMake error install FILES given directory for tools/validation (#3975) CMake error: install FILES given directory for tools/validation (#3975) Aug 30, 2024
@Shouren Shouren changed the title CMake error: install FILES given directory for tools/validation (#3975) CMake Error: install FILES given directory for tools/validation (#3975) Aug 30, 2024
@Shouren Shouren changed the title CMake Error: install FILES given directory for tools/validation (#3975) CMake Error: install FILES given directory for tools/validation Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (b278261) to head (4b8533f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3976      +/-   ##
============================================
- Coverage     74.80%   74.79%   -0.01%     
  Complexity      711      711              
============================================
  Files           762      762              
  Lines        137455   137453       -2     
  Branches       2013     2012       -1     
============================================
- Hits         102819   102814       -5     
- Misses        34333    34336       +3     
  Partials        303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

SDK Test Report

102 files  102 suites   2m 14s ⏱️
359 tests 345 ✅ 14 💤 0 ❌
487 runs  473 ✅ 14 💤 0 ❌

Results for commit 4b8533f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Linux Test Report

    60 files     253 suites   2h 0m 48s ⏱️
13 605 tests 13 598 ✅ 7 💤 0 ❌
19 317 runs  19 310 ✅ 7 💤 0 ❌

Results for commit 4b8533f.

♻️ This comment has been updated with latest results.

@Shouren Shouren changed the title CMake Error: install FILES given directory for tools/validation fix(tools): CMake Error install FILES given directory for tools/validation Aug 30, 2024
@Shouren Shouren changed the title fix(tools): CMake Error install FILES given directory for tools/validation fix(tools): cmake error install files given directory for tools/validation Aug 30, 2024
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 0c6b820 into 4paradigm:main Sep 6, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants