Enable c.indexing during tests, but patch it to not defer operations: #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasgraf
force-pushed
the
lg-use-collective-indexing-during-tests
branch
from
a4a0070 to
34814a8
Compare
We need to enable collective.indexing during tests in order to create Solr tests (because ftw.solr integrates itself by providing an IIndexQueueProcessor). So we need c.indexing's pluggable IndexQueueProcessor mechanism, but we don't want the unpredictable behavior of reindexes that are deferred until the end of the transaction during tests (or the queue getting flushed at arbitrary points). We therefore patch the IndexQueue's operation methods so that they always immediately process the queue after being called.
lukasgraf
force-pushed
the
lg-use-collective-indexing-during-tests
branch
from
34814a8 to
2fade44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to enable
collective.indexingduring tests in order to create Solr tests (becauseftw.solrintegrates itself by providing anIIndexQueueProcessor).So we need
collective.indexing's pluggableIndexQueueProcessormechanism, but we don't want the unpredictable behavior of reindexes that are deferred until the end of the transaction during tests (or the queue getting flushed at arbitrary points).We therefore patch the
IndexQueue's operation methods so that they always immediately process the queue after being called.Closes #5801
Note:
I checked for any negative effects on test runtime - wallclock time for tests on CI stayed exactly the same.
Checkliste