Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to query by token in @querysources API endpoint. #6608

Merged
merged 4 commits into from
Aug 31, 2020

Conversation

deiferni
Copy link
Contributor

@deiferni deiferni commented Aug 31, 2020

With this PR we allow the @querysources API endpoint to be queried by a token parameter in addition to the existing query parameter. The token can be used to retrieve the representation of one already known token. It will return an empty list if no such token exists.

Jira: https://4teamwork.atlassian.net/browse/PHX-10

Checklist (Must have)

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

@deiferni deiferni requested a review from a team August 31, 2020 12:42
Copy link
Contributor

@lukasgraf lukasgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for the docs regarding the schema intent! 🙈 🎉

@deiferni deiferni merged commit c0c6da0 into master Aug 31, 2020
@deiferni deiferni deleted the deif/phx-10-query-query-source-by-token branch August 31, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants