Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/graph equal optim #153

Draft
wants to merge 2 commits into
base: version/4.5
Choose a base branch
from

Conversation

justadreamer
Copy link
Contributor

According to the tests it gives a 1% performance gain compared to version/4.5 branch for a single property, however it seems that for all properties main branch performance dominates, version/4.5 does not seem to improve on it for all properties...

❯ cat summary-main.json
{
  "main":{
    "InMemoryAverage": 762823.41,
    "InMemory_AllAverage": 185975.2
  }, 
  "graph":{
    "InMemoryAverage": 875464.62,
    "InMemory_AllAverage": 174252.81
  },
  "4.5": {
    "InMemoryAverage": 866540.76,
    "InMemory_AllAverage": 171910.55
  }
} 

graph branch compared to version/4.5: 
for a single property:
(875464-866540)/866540*100% = 1.03%

for all properties:
(174252-171910)/174252*100% = 1.34%

@justadreamer justadreamer marked this pull request as draft December 6, 2024 14:22
@jwrosewell
Copy link
Contributor

@justadreamer a better test would be a single property from each of the components available rather than all properties which will be more random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants