feat: added prefix_path input that can be used to add a prefix to each filename in the cobertura report #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 47d3d6f.
kevinvalk
changed the title
kevinvalk
force-pushed
the
prefix
branch
2 times, most recently
from
c3259d7 to
ccc4fcb
Compare
…h filename in the cobertura report
kevinvalk
force-pushed
the
prefix
branch
2 times, most recently
from
81f5bc3 to
5012d04
Compare
|
This would be extremely useful. Is there anything I can do to help get this merged? |
|
Would appreciate pushing this to master as well. 🙏 |
Vadgyik
pushed a commit
to Vadgyik/cobertura-action
that referenced
this pull request
Jan 19, 2024
…h filename in the cobertura report applied 5monkeys#74 from https://github.com/kevinvalk/cobertura-action/tree/prefix
Vadgyik
added a commit
to Vadgyik/cobertura-action
that referenced
this pull request
Jan 23, 2024
… version (#1) * feat: added prefix_path input that can be used to add a prefix to each filename in the cobertura report applied 5monkeys#74 from https://github.com/kevinvalk/cobertura-action/tree/prefix * fix: update dependencies (npm audit fix) * feat: allow to set only desired output, add header_text, add outputs * feat: report total/covered line/branch count * improvement: upgrade to node20 --------- Co-authored-by: Kevin Valk <[email protected]>
Smip
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #59 introduces
link_missing_lines_source_dirwhich can be used to "fix" the generated URLs for the missing lines links. As far as I understand the real issue is due to the fact thefilenameinside the cobertura reports are not relative the root of the repository.As indicated in PR #59 there is a
<source>...</source>element in the cobertura report, but this may not always be correct.This PR add the provide
prefix_pathto ALLfilenameattributes. This fixes both thelink_missing_linesissue and also add support for showing the correct coverage when usingonly_changed_files.I added backwards compatibility to the
link_missing_lines_source_dir.