Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge: dev to main #330

Merged
merged 9 commits into from
Sep 8, 2024
Merged

Merge: dev to main #330

merged 9 commits into from
Sep 8, 2024

Conversation

cuconveniencestore
Copy link
Collaborator

☕ PR 타입

  • 기능 추가
  • 버그 수정
  • 코드 업데이트
  • 사소한 수정

☕ 작업 내용

  • SEO 수정
  • 클라우드플레어 저장소 경로 오류시 alt태그 노출, 상태 추가 후 기본 이미지로 변경로직 추가
  • 프로필 페이지 이미지 오류 로직 수정
  • 포스트 상세 페이지 이미지 오류 로직 추가

☕ 관련 issue

Copy link
Member

@hookor hookor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

e.currentTarget.style.opacity = '0';
}
};

return (
<>
{isError ? (
<Container>
<Suspense>
<ImageErrorCTA
text={'게시물을 불러올 수 없습니다.'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상수 같이 빼면 좋을 것 같습니다!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 이부분을 미쳐 확인 못했네요! 감사합니다!!

@cuconveniencestore cuconveniencestore merged commit 41f4bff into main Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Fix Error 수정 🧞‍♂️ 완료 작업 완료
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants