-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build settings to user settings. Add js_lint_folder command. #11
Conversation
Useful for sublime plugin development
Also, remove unnecessary keys "caption" and "mnemonic".
* Add js_lint_folder and js_lint_containing_folder commands. * Rename jslint to js_lint_file command. * Add js_lint_exec helper command. * Rename Default.sublime-commands to JSLint.sublime-commands as this is the standard. * Update context menu. * Add menu item "JSLint Folder" to side bar context menu. * Update sublime-commands.
This way linting multiple files (folders) is easy. Plus, it's nice to use the standard.
Awesome. Thanks! |
so how do I augment the .sublime-build file without getting it overwritten by each plugin-update? Where am I supposed to do it? Putting a custom JSLint.sublime-build to /Packages/User folder doesn't do the trick. |
UPD: I've found out it's done in .sublime-settings file (by looking into the .sublime-settings file here on github). I don't have that in my local .sublime-settings file though, my standard installed one contains only this: {
"filename_filter": "(\\.js|\\.css|\\.html|\\.json|\\.sass|\\.less)$"
} Seems like the PackageControl doesn't load the new version of the plugin. Any idea why? |
UPD 2: ok, it's actually effective only in @janraasch tree.. why is this still not in the master branch? |
There was a problem with Windows and |
I really like your plugin, but the problem about using a
.sublime-build
is that though a user can edit the build settings in thePackages/JSLint/JSLint.sublime-build
file, but those changes maybe overwritten any time the plugin is updated.So:
js_lint_exec
, which basically runs a custom build reading the settings merged from the defaultPackages/JSLint/JSLint.sublime-settings
and customPackages/JSLint/JSLint.sublime-settings
I do realize that this is basically a whole new plugin (codewise at least), but I don't want to add another sublimetext-jslint plugin to the package control repo, since there are already two of them. So, if you'd like to pull this stuff into your repo, please go ahead.