-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create finalManagementfile.html #21
base: main
Are you sure you want to change the base?
Conversation
update in search button and hover part of main file it show read book in place of click to read
Reviewer's Guide by SourceryThis PR introduces a new HTML file named No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for vrkpzs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ROHITKUMARMODI - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's an inconsistency in the button text - one instance shows 'Ride Book' instead of 'Read Book'. Please ensure consistent button text across all book items.
- Consider refactoring the repetitive category sections using templates or components to improve code maintainability and reduce duplication.
- The commit message and PR description should be more descriptive and clearly explain the changes being made. Please follow proper commit message conventions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
</div> | ||
<div class="book-overlay"> | ||
<button class="complete-btn">Complete</button> | ||
<button class="click-btn"> Ride Book</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Button text should be 'Read Book' instead of 'Ride Book' for consistency
<button class="click-btn"> Ride Book</button> | |
<button class="click-btn">Read Book</button> |
update in search button and hover part of main file it show read book in place of click to read use some hover changes by me
Summary by Sourcery
New Features: