-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create finalviewbfile.html #26
base: main
Are you sure you want to change the base?
Conversation
use genre filter
Reviewer's Guide by SourceryThis pull request introduces a new HTML file, Sequence diagram for genre filtering interactionsequenceDiagram
actor User
participant Filter as Genre Filter
participant Sections as Category Sections
participant Display as Book Display
User->>Filter: Select genre
Filter->>Sections: Get all sections
loop Each section
Filter->>Sections: Check category
alt Selected genre matches or 'all'
Sections->>Display: Show section
else No match
Sections->>Display: Hide section
end
end
Class diagram showing book management system structureclassDiagram
class Book {
+String title
+String genre
+String imageUrl
+Boolean isComplete
+openBook()
+markComplete()
}
class GenreFilter {
+String selectedGenre
+filterBooks()
+updateDisplay()
}
class CategorySection {
+String category
+Array~Book~ books
+display()
+hide()
}
GenreFilter --> CategorySection : filters
CategorySection --> Book : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for vrkpzs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ROHITKUMARMODI - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving inline styles to the CSS file to improve maintainability and follow separation of concerns principles
- The book listings contain significant repetition - consider using a data file/database and templating to generate the HTML dynamically rather than hardcoding all entries
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
use genre filter main role by Pravesh Arya of js function, css and direction of showing the things done by Rohit and Kallal
Summary by Sourcery
New Features: