App.js and Milpac.js refactor #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the readme prettier and much more comprehensive for first time users.
Merge from 7cav adr
Final version of the Pie-Chart-Testing fork. After merging with the 7Cav ADR, this branch will be deleted
Pie Chart - Main Merge
|
Known issue: uniqueNamesSet in CombinedFunction.js broke this update. As a temporary measure i have reverted to manual .length counting until a proper solution can be implemented. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructuring of MilpacParse.Js (now CombinedFunction.js) to allow for multiple functions including collapsible charts, and potential application for pie chart integration. Restructuring of app.js reduces total code from close to 600 lines to 313 lines in app.js.
Added objects to billetBank.js. Now, instead of pulling individual lists, you just select what lists you want from the billetBankObject.
billetBankObject now additionally has strings that go along with the billetID's.