Fix compile warnings in mantis-server-agent module Netflix#393

7ue5wu · Apr 4, 2023 · 0ccadcc · 0ccadcc
1 parent f94a508
commit 0ccadcc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/mantis-server/mantis-server-agent/build.gradle b/mantis-server/mantis-server-agent/build.gradle
@@ -25,9 +25,11 @@ dependencies {
     implementation libraries.spotifyFutures
     implementation libraries.slf4jApi
     implementation libraries.slf4jLog4j12
+    implementation 'org.jetbrains:annotations:16.0.2'
 
     testImplementation libraries.junit4
     testImplementation libraries.mockitoAll
     testImplementation project(":mantis-server:mantis-server-worker")
     testImplementation(testFixtures(project(":mantis-control-plane:mantis-control-plane-core")))
+    testImplementation 'com.google.code.findbugs:jsr305:3.0.2'
 }
diff --git a/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/BlobStore.java b/mantis-server/mantis-server-agent/src/main/java/io/mantisrx/server/agent/BlobStore.java
@@ -19,6 +19,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
+import javax.annotation.Nullable;
 import lombok.AccessLevel;
 import lombok.RequiredArgsConstructor;
 import net.lingala.zip4j.ZipFile;
@@ -37,7 +38,7 @@ public interface BlobStore extends Closeable {
      * @param prefixUri prefix that needs to be prepended to every requested resource.
      * @return blob store with the prefix patterns baked in.
      */
-    default BlobStore withPrefix(URI prefixUri) {
+    default BlobStore withPrefix(final URI prefixUri) {
         return new PrefixedBlobStore(prefixUri, this);
     }
 
@@ -50,8 +51,8 @@ default BlobStore withZipCapabilities() {
         return new ZipHandlingBlobStore(this);
     }
 
-    static BlobStore forHadoopFileSystem(URI clusterStoragePath, File localStoreDir) throws Exception {
-        final org.apache.hadoop.fs.FileSystem fileSystem =
+    static BlobStore forHadoopFileSystem(URI clusterStoragePath, File localStoreDir) throws IOException {
+        org.apache.hadoop.fs.FileSystem fileSystem =
             FileSystemInitializer.create(clusterStoragePath);
 
         return
@@ -111,7 +112,7 @@ private String getUnzippedDestDir(ZipFile zipFile) {
             return zipFile.getFile().getPath() + "-unzipped";
         }
 
-        private ZipFile getZipFile(File file) {
+        private static @Nullable ZipFile getZipFile(File file) {
             ZipFile file1 = new ZipFile(file);
             if (file1.isValidZipFile()) {
                 return file1;