fix clippy and typos error

bin/src/server/connector.rs

@@ -157,7 +157,6 @@ pub async fn run_media_connector(workers: usize, node: NodeConfig, args: Args) {
         loop {
             select! {
                 Some((from, ts, _req_id, req)) = connector_hook_rx.recv() => {
-                    log::error!("[MediaConnector] hook event {:?}", req);
                     hook_controller.on_event(from, ts, req);
                 }
                 _ = interval.tick()  => {
@@ -198,7 +197,6 @@ pub async fn run_media_connector(workers: usize, node: NodeConfig, args: Args) {
                 SdnExtOut::ServicesEvent(_, _, SE::Connector(event)) => match event {
                     media_server_connector::handler_service::Event::Req(from, ts, req_id, event) => {
                         let ev = event.clone();
-                        log::error!("[MediaConnector] hook event {:?}", ev);
                         if let Err(e) = connector_storage_tx.send((from, ts, req_id, event)).await {
                             log::error!("[MediaConnector] send event to storage error {:?}", e);
                         }

docs/user-guide/features/third-party-system-hook.md

@@ -26,7 +26,7 @@ Message will sent to another system by using JSON format, defined here:
     uuid: string,
     node: number,
     ts: number,
-    event: 'session' | 'peer' | 'remote_track' | 'loacl_track',
+    event: 'session' | 'peer' | 'remote_track' | 'local_track',
     payload: JSON
 }
 ```

packages/media_connector/src/hooks.rs

@@ -2,7 +2,7 @@ pub mod events;
 pub mod storage;
 pub mod worker;
 
-use std::{io::Error, sync::Arc};
+use std::{io::Error, rc::Rc, sync::Arc};
 
 use async_trait::async_trait;
 use atm0s_sdn::NodeId;
@@ -27,7 +27,7 @@ pub struct HookControllerCfg {
 pub struct ConnectorHookController {
     cfg: HookControllerCfg,
     workers: Vec<HookWorker>,
-    storage: Arc<dyn HookStorage>,
+    storage: Rc<dyn HookStorage>,
 }
 
 impl ConnectorHookController {
@@ -39,7 +39,7 @@ impl ConnectorHookController {
         Self {
             cfg,
             workers,
-            storage: Arc::new(storage::InMemoryHookStorage::default()),
+            storage: Rc::new(storage::InMemoryHookStorage::default()),
         }
     }
 
@@ -212,14 +212,12 @@ impl ConnectorHookController {
     }
 
     pub async fn on_tick(&mut self) {
-        // log::error!("on_tick: on worker ticks");
         for worker in self.workers.iter_mut() {
             worker.on_tick().await;
         }
 
         let jobs = self.storage.jobs(self.cfg.job_num as i16);
         for job in jobs.iter() {
-            // log::error!("job: {:?}", job.payload);
             let path = job.payload.session() % (self.cfg.worker_num as u64);
             self.workers[path as usize].push(job.clone());
         }

packages/media_connector/src/hooks/storage.rs

@@ -1,4 +1,4 @@
-use std::sync::{Arc, RwLock};
+use std::{rc::Rc, sync::RwLock};
 
 use media_server_utils::now_ms;
 
@@ -8,7 +8,7 @@ use super::events::HookEvent;
 pub struct HookJobData {
     pub payload: HookEvent,
     pub ts: u64,
-    on_done: Arc<dyn Fn(String)>,
+    on_done: Rc<dyn Fn(String)>,
 }
 
 impl HookJobData {
@@ -23,18 +23,19 @@ pub trait HookStorage {
     fn clean_timeout_event(&self, now: u64);
 }
 
+#[derive(Default)]
 pub struct InMemoryHookStorage {
-    queue: Arc<RwLock<Vec<HookJobData>>>,
+    queue: Rc<RwLock<Vec<HookJobData>>>,
 }
 
 impl InMemoryHookStorage {
-    pub fn default() -> Self {
-        Self { queue: Default::default() }
-    }
-
     pub fn len(&self) -> usize {
         self.queue.read().unwrap().len()
     }
+
+    pub fn is_empty(&self) -> bool {
+        self.queue.read().unwrap().is_empty()
+    }
 }
 
 impl HookStorage for InMemoryHookStorage {
@@ -44,7 +45,7 @@ impl HookStorage for InMemoryHookStorage {
             let mut queue = cloned_queue.write().unwrap();
             queue.retain(|job| job.payload.id() != uuid.as_str());
         };
-        let ack = Arc::new(ack);
+        let ack = Rc::new(ack);
         let mut queue = self.queue.write().unwrap();
         queue.push(HookJobData {
             payload: data,