Skip to content

Commit

Permalink
fix clippy
Browse files Browse the repository at this point in the history
  • Loading branch information
giangndm committed Nov 21, 2024
1 parent 890aea4 commit c86899d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions packages/media_core/src/cluster/room/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ impl<Endpoint: Debug + Hash + Eq + Copy> RoomMetadata<Endpoint> {
None
};

let subscribers = self.peers_map_subscribers.iter().map(|a| a.clone()).collect::<Vec<_>>();
let subscribers = self.peers_map_subscribers.iter().copied().collect::<Vec<_>>();
if let Some(info) = info {
log::info!("[ClusterRoom {}] cluster: peer {} joined => fire event to {:?}", self.room, info.peer, subscribers);
self.cluster_peers.insert(peer_key, info.clone());
Expand All @@ -273,7 +273,7 @@ impl<Endpoint: Debug + Hash + Eq + Copy> RoomMetadata<Endpoint> {
None
};

let subscribers = self.tracks_map_subscribers.iter().map(|a| a.clone()).collect::<Vec<_>>();
let subscribers = self.tracks_map_subscribers.iter().copied().collect::<Vec<_>>();
if let Some(info) = info {
log::info!(
"[ClusterRoom {}] cluster: peer ({}) started track {}) => fire event to {:?}",
Expand Down Expand Up @@ -310,7 +310,7 @@ impl<Endpoint: Debug + Hash + Eq + Copy> RoomMetadata<Endpoint> {
None
};

let subscribers = return_if_none!(self.peers_tracks_subs.get(&peer_map)).iter().map(|a| a.clone()).collect::<Vec<_>>();
let subscribers = return_if_none!(self.peers_tracks_subs.get(&peer_map)).iter().copied().collect::<Vec<_>>();
if let Some(info) = info {
log::info!(
"[ClusterRoom {}] cluster: peer ({}) started track {}) => fire event to {:?}",
Expand Down
6 changes: 3 additions & 3 deletions packages/media_runner/src/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ mod test {

#[test]
fn smallmap_collision() {
for i in 0..1000_000 {
for i in 0..1_000_000 {
let mut map = indexmap::IndexMap::new();
let webrtc = MediaClusterEndpoint::Webrtc(WebrtcSession::from(rand::random::<usize>()));
map.insert(webrtc, ());
Expand All @@ -753,11 +753,11 @@ mod test {
map.swap_remove(&webrtc);

assert_eq!(map.len(), 1);
assert_eq!(map.is_empty(), false, "first failsed, cycle {i} {webrtc:?} {rtpengine:?}");
assert!(!map.is_empty(), "first failsed, cycle {i} {webrtc:?} {rtpengine:?}");

map.swap_remove(&rtpengine);
assert_eq!(map.len(), 0);
assert_eq!(map.is_empty(), true, "second failsed, cycle {i} {webrtc:?} {rtpengine:?}");
assert!(map.is_empty(), "second failsed, cycle {i} {webrtc:?} {rtpengine:?}");
}
}
}

0 comments on commit c86899d

Please sign in to comment.