ci: fix clippy actions workflow and add cargo-fmt action #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed the job from "rust-clippy-analyze" to "rust-fmt-analyze" - Updated the name of the job to "Run rust-fmt analyzing" - Removed unused permissions for "security-events" and "actions" - Added the step to configure the cache for cargo - Updated the command to run "cargo fmt"
- Update the configuration for running rust-clippy in GitHub Actions - Update the version of the Actions used in the workflow - Refactor the rust-fmt job in GitHub Actions to remove the continue-on-error flag
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 41.62% 41.61% -0.01%
==========================================
Files 134 134
Lines 14120 14120
==========================================
- Hits 5877 5876 -1
- Misses 8243 8244 +1 ☔ View full report in Codecov by Sentry. |
|
@giangndm Can you please delete the 94MB Cache from here? https://github.com/8xFF/atm0s-media-server/actions/caches Duplicate cache got created because of workflow race condition |
|
@dhilipsiva I just clear all caches. |
|
@giangndm Do you want me to make anymore changes on this? |
giangndm
approved these changes
Jul 18, 2024
giangndm
pushed a commit
to giangndm/8xFF-decentralized-media-server
that referenced
this pull request
Nov 26, 2024
* ci: Improve workflow configuration and code formatting * chore: cargo fmt and install protoc * chore: fix rust-clippy and rust-fmt * ci: Refactor GitHub actions for rust-fmt workflow - Renamed the job from "rust-clippy-analyze" to "rust-fmt-analyze" - Updated the name of the job to "Run rust-fmt analyzing" - Removed unused permissions for "security-events" and "actions" - Added the step to configure the cache for cargo - Updated the command to run "cargo fmt" * test: break clippy on purpose to test GH Actions * Refactor GitHub workflows and protoc compilation * chore: Update GitHub workflows for Rust code analysis - Update the configuration for running rust-clippy in GitHub Actions - Update the version of the Actions used in the workflow - Refactor the rust-fmt job in GitHub Actions to remove the continue-on-error flag * ci: Improve GitHub actions for Rust codebase * ci: fail clippy while piping, if need be * ci: Update GitHub Actions workflow for rust-clippy * ci: fix clippy warnings * ci: fix last error * ci: restore comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy was already being used. But it never reported any problems. The errors were always suppressed because we were piping the clippy output to cargo-sarif. This piping masked the exit code of clippy command. Which is why you might notice clippy is run twice now.
Note: actions-rs was deprecated and archived because GH Actions now support for rust by default: https://github.com/actions/starter-workflows/blob/main/ci/rust.yml
Apart from this, I have also added a cargo fmt action, added cache support and fixed remaining clippy warnings.
CC: @giangndm: #349 (comment)
Checklist