Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api missing data #355

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix: api missing data #355

merged 3 commits into from
Jul 19, 2024

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Jul 19, 2024

Pull Request

Description

This PR fix missing data in bellow apis:

  • peers log
  • sessions log

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

N/A

Additional Notes

Currently sea-orm don't support two find_with_related then we need collect data in multiple queries, should fix in future

@giangndm giangndm marked this pull request as ready for review July 19, 2024 04:31
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 26 lines in your changes missing coverage. Please review.

Project coverage is 41.66%. Comparing base (da3d144) to head (ac4466f).
Report is 1 commits behind head on master.

Files Patch % Lines
bin/src/http/api_console/connector.rs 0.00% 11 Missing ⚠️
packages/media_connector/src/sql_storage.rs 86.95% 9 Missing ⚠️
bin/src/server/connector/remote_rpc_handler.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   41.62%   41.66%   +0.04%     
==========================================
  Files         134      134              
  Lines       14120    14159      +39     
==========================================
+ Hits         5877     5899      +22     
- Misses       8243     8260      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit 9e2b43a into 8xFF:master Jul 19, 2024
11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* add peers number to rooms api

* fix: some log apis missing data

* fix clippy warns
@giangndm giangndm deleted the fix-api-missing-data branch November 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant