Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rtp transport #424

Merged
merged 8 commits into from
Sep 4, 2024
Merged

feat: rtp transport #424

merged 8 commits into from
Sep 4, 2024

Conversation

giangndm
Copy link
Contributor

Pull Request

Description

This PR implements RTP transport with HTTP APIs. This is useful for using with drachtio instead of RtpEngine protocol

Related Issue

If this pull request is related to any issue, please mention it here.

Checklist

  • I have tested the changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation, if necessary.
  • I have added appropriate tests, if applicable.

Screenshots

If applicable, add screenshots to help explain the changes made.

Additional Notes

Add any additional notes or context about the pull request here.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0.12500% with 799 lines in your changes missing coverage. Please review.

Project coverage is 39.64%. Comparing base (f7b201a) to head (e4f4f67).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/transport_rtpengine/src/transport.rs 0.00% 143 Missing ⚠️
bin/src/http/api_media/rtpengine.rs 0.00% 102 Missing ⚠️
bin/src/http.rs 0.00% 95 Missing ⚠️
bin/src/http/api_media/webrtc.rs 0.00% 93 Missing ⚠️
packages/protocol/src/protobuf/cluster_gateway.rs 0.00% 77 Missing ⚠️
bin/src/http/api_media/whip.rs 0.00% 72 Missing ⚠️
bin/src/http/api_media/whep.rs 0.00% 71 Missing ⚠️
bin/src/server/gateway/local_rpc_handler.rs 0.00% 34 Missing ⚠️
packages/protocol/src/transport/rtpengine.rs 0.00% 32 Missing ⚠️
bin/src/server/gateway/remote_rpc_handler.rs 0.00% 25 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   40.71%   39.64%   -1.07%     
==========================================
  Files         154      157       +3     
  Lines       16642    17077     +435     
==========================================
- Hits         6775     6770       -5     
- Misses       9867    10307     +440     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review September 4, 2024 03:55
@giangndm giangndm merged commit 0dd24e9 into 8xFF:master Sep 4, 2024
9 of 11 checks passed
giangndm added a commit to giangndm/8xFF-decentralized-media-server that referenced this pull request Nov 26, 2024
* refactor: split big media api to small modules

* wip: added rtp engine http apis. added rtp engine offer mode

* fixed http openapi uri

* fixed rtpengine and webrtc in same room

* fix derive_more

* feat: auto timeout rtpengine endpoint after 60s no send or recv

* feat: switch rtpengine timeout with 2 ways audio
@giangndm giangndm deleted the feat-rtp-transport branch November 26, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant